Skip to content

feat(arbitrage): Introduce trade counter & test mode flag with full NatSpec documentation #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DianaRicee merged 2 commits into from
Oct 1, 2025
Merged

feat(arbitrage): Introduce trade counter & test mode flag with full NatSpec documentation #147

DianaRicee merged 2 commits into from
Oct 1, 2025

Conversation

@Neros0
Copy link
Contributor

@Neros0 Neros0 commented Oct 1, 2025

Description

This PR enhances the TestArbitrage contract with two important state variables designed to support tracking, analytics, and controlled simulation flows.

✅ Key Additions

Variable Type Purpose
tradeCounter uint256 Auto-incrementing counter used to uniquely identify each executed trade
testMode bool Toggle that enables special testing/simulation-only logic without affecting production execution

📦 Code Changes

/// @notice Counter for trade IDs
/// @dev Incremented for each new trade
uint256 public tradeCounter;

/// @notice Test mode flag for simulation purposes
/// @dev When true, enables additional testing features
bool public testMode;

@DianaRicee DianaRicee self-requested a review October 1, 2025 17:59
@DianaRicee DianaRicee added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 1, 2025
@DianaRicee DianaRicee merged commit 2f24015 into main Oct 1, 2025
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DianaRicee DianaRicee DianaRicee approved these changes

Assignees

@Neros0 Neros0

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Neros0 @DianaRicee